-
Notifications
You must be signed in to change notification settings - Fork 102
Support agent available rollback fields #5975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
529235c to
68867ee
Compare
68867ee to
79698cd
Compare
|
I am actually good with this PR. I don't want to override @michalpristas comments about the available rollbacks, but if he also agrees to keep them seperate then I am +1 |
|
I'm good with it paolo explained reasoning offline |
cmacknz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides my one remaining comment.
When we are done with these changes, it would be good to update the horde drones to report as having available rollbacks so that the scale tests exercise these code paths.
8a1c4fd to
7009b95
Compare
7009b95 to
f026157
Compare
What is the problem this PR solves?
This PR handles new
available_rollbacksfield sent by elastic-agent during checkin (implemented in PR elastic/elastic-agent#11143).This information will be consumed by the Fleet UI to allow a manual rollback of recently upgraded agents.
How does this PR solve the problem?
This PR introduces new
available_rollbacksfield both inCheckinRequestandpendingTstructs as a slice ofAvailableRollbacksand a JSON array of objects respectively.On Elasticsearch the documents in
.fleet-agentswill have a new fieldupgrade.rollbackssimilar to:How to test this PR locally
Refer to PR elastic/elastic-agent#11143
How to test this PR locallysection.Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues